[Framework] Cmake: set warnings-as-errors in all the Framework targets#6145
Open
fredroy wants to merge 2 commits into
Open
[Framework] Cmake: set warnings-as-errors in all the Framework targets#6145fredroy wants to merge 2 commits into
fredroy wants to merge 2 commits into
Conversation
fredroy
added
pr: status to review
fredroy
changed the title
fredroy
force-pushed
the
framework_warnings_as_errors
branch
6 times, most recently
from
9048206 to
d2e7617
Compare
Contributor
Author
|
[ci-build][with-all-tests] |
fredroy
added
the
pr: based on previous PR
fredroy
force-pushed
the
framework_warnings_as_errors
branch
from
d2e7617 to
04cd3bd
Compare
Contributor
|
When updating of VMs / CIs, warnings are to be expected therefore creating errors. Let's discuss this with @bakpaul |
fredroy
force-pushed
the
framework_warnings_as_errors
branch
from
04cd3bd to
02ee377
Compare
fredroy
removed
the
pr: based on previous PR
Contributor
|
Yes indeed, I would like to merge it after the CI migration ! |
alxbilger
added
the
pr: highlighted in next release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on
The continuation of #5914 ,#6027, #6028, #6034.
This should make the compilation of the target Sofa.Framework warning-free.... with the current flags.
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if